From 316a7a6ab188a5c7b122b64bd187347bbaa514db Mon Sep 17 00:00:00 2001
From: Frederik Ring <frederik.ring@gmail.com>
Date: Sat, 27 Jan 2024 19:48:50 +0100
Subject: [PATCH] Inline handling of in-swarm container level restart

---
 cmd/backup/docker.go | 49 ++++++++++++++++++--------------------------
 1 file changed, 20 insertions(+), 29 deletions(-)

diff --git a/cmd/backup/docker.go b/cmd/backup/docker.go
index 9caaad4..87de18d 100644
--- a/cmd/backup/docker.go
+++ b/cmd/backup/docker.go
@@ -229,46 +229,37 @@ func (s *script) stopContainersAndServices() (func() error, error) {
 	}
 
 	return func() error {
-		servicesRequiringForceUpdate := map[string]struct{}{}
-
 		var restartErrors []error
+		matchedServices := map[string]bool{}
 		for _, container := range stoppedContainers {
-			// in case a container was part of a swarm service, teh service requires to
-			// be force updated instead of restarting the container as it would otherwise
-			// remain in a "completed" state
-			if swarmServiceName, ok := container.Labels["com.docker.swarm.service.name"]; ok {
-				servicesRequiringForceUpdate[swarmServiceName] = struct{}{}
-				continue
-			}
-			if err := s.cli.ContainerStart(context.Background(), container.ID, types.ContainerStartOptions{}); err != nil {
-				restartErrors = append(restartErrors, err)
-			}
-		}
-
-		if len(servicesRequiringForceUpdate) != 0 {
-			services, _ := s.cli.ServiceList(context.Background(), types.ServiceListOptions{})
-			for serviceName := range servicesRequiringForceUpdate {
-				var serviceMatch swarm.Service
-				for _, service := range services {
-					if service.Spec.Name == serviceName {
-						serviceMatch = service
-						break
-					}
+			if swarmServiceID, ok := container.Labels["com.docker.swarm.service.id"]; ok && isDockerSwarm {
+				if _, ok := matchedServices[swarmServiceID]; ok {
+					continue
 				}
-				if serviceMatch.ID == "" {
+				matchedServices[swarmServiceID] = true
+				// in case a container was part of a swarm service, the service requires to
+				// be force updated instead of restarting the container as it would otherwise
+				// remain in a "completed" state
+				service, _, err := s.cli.ServiceInspectWithRaw(context.Background(), swarmServiceID, types.ServiceInspectOptions{})
+				if err != nil {
 					restartErrors = append(
 						restartErrors,
-						fmt.Errorf("(*script).stopContainersAndServices: couldn't find service with name %s", serviceName),
+						fmt.Errorf("(*script).stopContainersAndServices: error looking up parent service: %w", err),
 					)
 					continue
 				}
-				serviceMatch.Spec.TaskTemplate.ForceUpdate += 1
+				service.Spec.TaskTemplate.ForceUpdate += 1
 				if _, err := s.cli.ServiceUpdate(
-					context.Background(), serviceMatch.ID,
-					serviceMatch.Version, serviceMatch.Spec, types.ServiceUpdateOptions{},
+					context.Background(), service.ID,
+					service.Version, service.Spec, types.ServiceUpdateOptions{},
 				); err != nil {
 					restartErrors = append(restartErrors, err)
 				}
+				continue
+			}
+
+			if err := s.cli.ContainerStart(context.Background(), container.ID, types.ContainerStartOptions{}); err != nil {
+				restartErrors = append(restartErrors, err)
 			}
 		}
 
@@ -297,7 +288,7 @@ func (s *script) stopContainersAndServices() (func() error, error) {
 		allErrors := append(restartErrors, scaleUpErrors.value()...)
 		if len(allErrors) != 0 {
 			return fmt.Errorf(
-				"stopContainers: %d error(s) restarting containers and services: %w",
+				"(*script).stopContainersAndServices: %d error(s) restarting containers and services: %w",
 				len(allErrors),
 				errors.Join(allErrors...),
 			)