offen/docker-volume-backup
2
0
Fork 0
mirror of https://github.com/offen/docker-volume-backup.git synced 2024-11-10 00:30:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

do not use scanner to write file in chunks

Browse Source
This commit is contained in:
Frederik Ring 2021-08-23 15:19:50 +02:00
parent f4f4fa9e74
commit ec87bd27e7
1 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
cmd/backup/main.go
View File

@ -4,7 +4,6 @@
package main package main
import ( import (
"bufio"
"bytes" "bytes"
"context" "context"
"errors" "errors"
@ -276,26 +275,11 @@ func (s *script) encryptBackup() error {
return fmt.Errorf("encryptBackup: error encrypting backup file: %w", err) return fmt.Errorf("encryptBackup: error encrypting backup file: %w", err)
} }
file, err := os.Open(s.file) b, err := ioutil.ReadFile(s.file)
if err != nil { if err != nil {
return fmt.Errorf("encryptBackup: error opening unencrypted backup file: %w", err) return fmt.Errorf("encryptBackup: error opening unencrypted backup file: %w", err)
} }
pt.Write(b)
// backup files might be very large, so they are being read in chunks instead
// of loading them into memory once.
scanner := bufio.NewScanner(file)
chunk := make([]byte, 0, 1024*1024)
scanner.Buffer(chunk, 10*1024*1024)
for scanner.Scan() {
_, err = pt.Write(scanner.Bytes())
if err != nil {
file.Close()
pt.Close()
return fmt.Errorf("encryptBackup: error encrypting backup contents: %w", err)
}
}
file.Close()
pt.Close() pt.Close()
gpgFile := fmt.Sprintf("%s.gpg", s.file) gpgFile := fmt.Sprintf("%s.gpg", s.file)