mirror of
https://github.com/offen/docker-volume-backup.git
synced 2024-09-20 05:30:26 +02:00
Frederik Ring
c3daeacecb
* Query for labeled services as well * Try scaling down services * Scale services back up * Use progress tool from Docker CLI * In test, label both services * Clean up error and log messages * Document scale-up/down approach in docs * Downgrade Docker CLI to match client * Document services stats * Do not rely on PreviousSpec for storing desired replica count * Log warnings from Docker when updating services * Check whether container and service labels collide * Document script behavior on label collision * Add additional check if all containers have been removed * Scale services concurrently * Move docker interaction code into own file * Factor out code for service updating * Time out after five minutes of not reaching desired container count * Inline handling of in-swarm container level restart * Timer is more suitable for timeout race * Timeout when scaling down services should be configurable * Choose better filename * Reflect changes in naming * Rename and deprecate BACKUP_STOP_CONTAINER_LABEL * Improve logging * Further simplify logging
20 lines
663 B
Markdown
20 lines
663 B
Markdown
---
|
|
title: Replace deprecated BACKUP_STOP_CONTAINER_LABEL setting
|
|
layout: default
|
|
parent: How Tos
|
|
nav_order: 19
|
|
---
|
|
|
|
# Replace deprecated `BACKUP_STOP_CONTAINER_LABEL` setting
|
|
|
|
Version `v2.36.0` deprecated the `BACKUP_STOP_CONTAINER_LABEL` setting and renamed it `BACKUP_STOP_DURING_BACKUP_LABEL` which is supposed to signal that this will stop both containers _and_ services.
|
|
Migrating is done by renaming the key for your custom value:
|
|
|
|
```diff
|
|
env:
|
|
- BACKUP_STOP_CONTAINER_LABEL: database
|
|
+ BACKUP_STOP_DURING_BACKUP_LABEL: database
|
|
```
|
|
|
|
The old key will stay supported until the next major version, but logs a warning each time a backup is taken.
|